Wasmtime GitHub notifications bot (Oct 01 2024 at 20:56): Wasmtime GitHub notifications bot (Oct 01 2024 at 20:56):saulecabrera requested abrown for a review on PR #9354.
Wasmtime GitHub notifications bot (Oct 01 2024 at 20:56):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9354.
Wasmtime GitHub notifications bot (Oct 01 2024 at 20:56):saulecabrera opened PR #9354 from saulecabrera:winch-properly-id-dest-regs to bytecodealliance:main:
No functional changes are introduced as part of this change.
This commit introduces a formal mechanism for identifying destination registers in Winch's MacroAssembler and Assembler layers.
Before this change, there was no standardized way to identify writable registers, which made it challenging to:
- Audit register clobbering effectively.
- Establish a consistent approach for defining new MacroAssembler methods, as the identification of writable registers was done ad-hoc and varied from method to method.
This enhancement aims to improve code maintainability and reduce potential errors related to register management.
This commit makes use of Cranelift's
Writable<T>type to identify writable registers.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 01 2024 at 22:44):github-actions[bot] commented on PR #9354:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Oct 02 2024 at 00:25):abrown submitted PR review.
Wasmtime GitHub notifications bot (Oct 02 2024 at 01:01):saulecabrera merged PR #9354.
Last updated: Oct 23 2024 at 20:03 UTC