Stream: git-wasmtime

Topic: wasmtime / PR #9332 feat(cli): allow underscores for nume...

Wasmtime GitHub notifications bot (Sep 30 2024 at 11:40):

vados-cosmonic requested fitzgen for a review on PR #9332.

Wasmtime GitHub notifications bot (Sep 30 2024 at 11:40):

vados-cosmonic opened PR #9332 from vados-cosmonic:feat(cli)=allow-underscores-for-numeric-options to bytecodealliance:main:

This commit allows for underscores to be used in numeric arguments to the wasmtime CLI.

For example, a string like 1_200 will be interpreted as 1200.

This change would make it easier to enter large values (ex. --max-memory-size) when using wasmtime via CLI

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 30 2024 at 11:40):

vados-cosmonic requested wasmtime-core-reviewers for a review on PR #9332.

Wasmtime GitHub notifications bot (Sep 30 2024 at 14:40):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Sep 30 2024 at 14:59):

alexcrichton merged PR #9332.

Last updated: Dec 23 2024 at 13:07 UTC