Stream: git-wasmtime

Topic: wasmtime / PR #9330 Update region to 3.0.2

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2024 at 22:34):

sunshowers requested abrown for a review on PR #9330.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2024 at 22:34):

sunshowers requested wasmtime-compiler-reviewers for a review on PR #9330.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2024 at 22:34):

sunshowers requested wasmtime-default-reviewers for a review on PR #9330.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2024 at 22:34):

sunshowers opened PR #9330 from sunshowers:update-region to bytecodealliance:main:

Hi there -- I've been working on some code changes to wasmtime and I noticed that the region dependency was out of date. Here's a PR to update the dependency to version 3.

The main difference is that region::page::ceil now works on addresses rather than usizes, so there's a small adaptation for that in this PR. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2024 at 22:37):

sunshowers edited PR #9330:

Hi there -- I've been working on some code changes to wasmtime (primarily around illumos support) and I noticed that the region dependency was out of date. Here's a PR to update the dependency to version 3, which supports illumos.

The main difference is that region::page::ceil now works on addresses rather than usizes, so there's a small adaptation for that in this PR. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2024 at 22:38):

sunshowers edited PR #9330:

Hi there -- I've been working on some code changes to wasmtime (primarily around illumos support) and I noticed that the region dependency was out of date. Here's a PR to update the dependency to version 3, which supports illumos.

The main API difference is that region::page::ceil now works on addresses rather than usizes, so there's a small adaptation for that in this PR. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2024 at 14:33):

alexcrichton updated PR #9330.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2024 at 14:34):

alexcrichton submitted PR review:

Thanks for the PR!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2024 at 14:34):

alexcrichton has enabled auto merge for PR #9330.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2024 at 15:00):

alexcrichton merged PR #9330.

Last updated: Nov 22 2024 at 16:03 UTC