Stream: git-wasmtime

Topic: wasmtime / PR #9328 Reexport `wasmtime::hash_{map,set}` f...

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:20):

fitzgen requested elliottt for a review on PR #9328.

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:20):

fitzgen opened PR #9328 from fitzgen:wasmtime-crate-hash-map to bytecodealliance:main:

Some modules were using std::collections::{HashMap, HashSet} when they knew that they were only compiled when the std feature was enabled. But we need to use hashbrown in certain other places (Cranelift's e-graphs, pooling allocator's index allocator, etc.), so we should simply use hashbrown everywhere. This should reduce binary size some small amount, but also means that we never have to ask ourselves "which hash map should I import?" when adding a new hash map import: always use crate::hash_map::HashMap et al.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:20):

fitzgen requested wasmtime-core-reviewers for a review on PR #9328.

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:33):

fitzgen updated PR #9328.

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:41):

fitzgen updated PR #9328.

Wasmtime GitHub notifications bot (Sep 29 2024 at 01:05):

github-actions[bot] commented on PR #9328:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 29 2024 at 02:13):

github-actions[bot] commented on PR #9328:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Sep 30 2024 at 14:41):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2024 at 14:59):

alexcrichton merged PR #9328.

Last updated: Nov 22 2024 at 17:03 UTC