fitzgen requested alexcrichton for a review on PR #9326.
fitzgen opened PR #9326 from fitzgen:gc-array-instructions
to bytecodealliance:main
:
This does not implement
array.copy
andarray.init_elem
yet, but implements all otherarray.*
instructions:
array.new
array.new_fixed
array.new_default
array.new_data
array.new_elem
array.fill
array.init_data
array.len
array.get
array.get_s
array.get_u
array.set
Note that the initial plumbing for
array.{copy,init_elem}
is in place, but the instructions themselves are not implemented yet.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested elliottt for a review on PR #9326.
fitzgen requested wasmtime-compiler-reviewers for a review on PR #9326.
fitzgen requested wasmtime-core-reviewers for a review on PR #9326.
fitzgen updated PR #9326.
fitzgen updated PR #9326.
fitzgen updated PR #9326.
fitzgen updated PR #9326.
fitzgen updated PR #9326.
fitzgen updated PR #9326.
github-actions[bot] commented on PR #9326:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton submitted PR review.
alexcrichton created PR review comment:
stray debug?
alexcrichton created PR review comment:
This looks pretty similar to
translate_array_fill
above, would it be possible to refactor the two to share more code?
alexcrichton created PR review comment:
Could
translate_init_gc_reference
below internally do this so it doesn't have to be done each time a translate helper is called? (I saw this above as well for writes I think)
alexcrichton created PR review comment:
Worth using a destructor here for panic-safety?
fitzgen requested wasmtime-fuzz-reviewers for a review on PR #9326.
fitzgen updated PR #9326.
fitzgen submitted PR review.
fitzgen created PR review comment:
thanks, yeah
fitzgen created PR review comment:
good idea
fitzgen submitted PR review.
fitzgen submitted PR review.
fitzgen created PR review comment:
I actually like having it repeated, so I know exactly all the places I need to fix up later (which I plan on doing soon, so that I can run some of the spec tests that use funcrefs)
fitzgen updated PR #9326.
fitzgen has enabled auto merge for PR #9326.
fitzgen merged PR #9326.
Last updated: Dec 23 2024 at 12:05 UTC