Stream: git-wasmtime

Topic: wasmtime / PR #9326 Implement most `array.*` instructions...

Wasmtime GitHub notifications bot (Sep 28 2024 at 21:55):

fitzgen requested alexcrichton for a review on PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 21:55):

fitzgen opened PR #9326 from fitzgen:gc-array-instructions to bytecodealliance:main:

This does not implement array.copy and array.init_elem yet, but implements all other array.* instructions:

• array.new
• array.new_fixed
• array.new_default
• array.new_data
• array.new_elem
• array.fill
• array.init_data
• array.len
• array.get
• array.get_s
• array.get_u
• array.set

Note that the initial plumbing for array.{copy,init_elem} is in place, but the instructions themselves are not implemented yet.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 28 2024 at 21:55):

fitzgen requested elliottt for a review on PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 21:55):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 21:55):

fitzgen requested wasmtime-core-reviewers for a review on PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 22:35):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 22:41):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:30):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:40):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:42):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 28 2024 at 23:58):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 29 2024 at 02:13):

github-actions[bot] commented on PR #9326:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 30 2024 at 15:44):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2024 at 15:44):

alexcrichton created PR review comment:

stray debug?

Wasmtime GitHub notifications bot (Sep 30 2024 at 15:44):

alexcrichton created PR review comment:

This looks pretty similar to translate_array_fill above, would it be possible to refactor the two to share more code?

Wasmtime GitHub notifications bot (Sep 30 2024 at 15:44):

alexcrichton created PR review comment:

Could translate_init_gc_reference below internally do this so it doesn't have to be done each time a translate helper is called? (I saw this above as well for writes I think)

Wasmtime GitHub notifications bot (Sep 30 2024 at 15:44):

alexcrichton created PR review comment:

Worth using a destructor here for panic-safety?

Wasmtime GitHub notifications bot (Sep 30 2024 at 16:49):

fitzgen requested wasmtime-fuzz-reviewers for a review on PR #9326.

Wasmtime GitHub notifications bot (Sep 30 2024 at 16:49):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 30 2024 at 18:22):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2024 at 18:22):

fitzgen created PR review comment:

thanks, yeah

Wasmtime GitHub notifications bot (Sep 30 2024 at 19:06):

fitzgen created PR review comment:

good idea

Wasmtime GitHub notifications bot (Sep 30 2024 at 19:06):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2024 at 19:07):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2024 at 19:07):

fitzgen created PR review comment:

I actually like having it repeated, so I know exactly all the places I need to fix up later (which I plan on doing soon, so that I can run some of the spec tests that use funcrefs)

Wasmtime GitHub notifications bot (Sep 30 2024 at 19:12):

fitzgen updated PR #9326.

Wasmtime GitHub notifications bot (Sep 30 2024 at 19:13):

fitzgen has enabled auto merge for PR #9326.

Wasmtime GitHub notifications bot (Sep 30 2024 at 19:40):

fitzgen merged PR #9326.

Last updated: Oct 23 2024 at 20:03 UTC