wasmtime / PR #9325 Enable a few miscellaneous Clippy lints · git-wasmtime

I'm curious about the changes to the preview1 module removing all the .context calls, but other than that these all seem like great improvements :+1:

Wasmtime GitHub notifications bot (Sep 28 2024 at 20:44):

github-actions[bot] commented on PR #9325:

Subscribe to Label Action

cc @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "wasi", "wasmtime:api", "wasmtime:ref-types", "winch"

Thus the following users have been cc'd because of the following labels:

fitzgen: wasmtime:ref-types

saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 01 2024 at 17:53):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 01 2024 at 17:53):

alexcrichton created PR review comment:

Intentional yeah, turns out that the try_into in these cases was infallible and couldn't ever fail. That meant that the error case never happened and the .context(...) calls were basically all dead code. I switched them all over to using ? which leverages the into conversion automatically which is known to never fail.

Wasmtime GitHub notifications bot (Oct 01 2024 at 17:55):

alexcrichton updated PR #9325.

Wasmtime GitHub notifications bot (Oct 01 2024 at 17:55):

alexcrichton has enabled auto merge for PR #9325.

Wasmtime GitHub notifications bot (Oct 01 2024 at 19:57):

alexcrichton merged PR #9325.

Last updated: Dec 23 2024 at 12:05 UTC