Stream: git-wasmtime

Topic: wasmtime / PR #9322 bug: bindgen erraneously parses extra...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 15:19):

lwansbrough opened PR #9322 from lwansbrough:feature/paths-fix to bytecodealliance:main:

Fixes an issue introduced in #9288 where an additional comma token is erroneously consumed. This meant if path was not the last property in the bindgen options, you would see an error "expected ,"

The provided tests were simple enough that path happened to be the last property. I haven't included a new test here because I think testing for such an issue is outside the scope of the tests.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 15:19):

lwansbrough requested wasmtime-core-reviewers for a review on PR #9322.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 15:19):

lwansbrough requested alexcrichton for a review on PR #9322.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 16:28):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 16:44):

alexcrichton merged PR #9322.

Last updated: Nov 22 2024 at 16:03 UTC