Stream: git-wasmtime

Topic: wasmtime / PR #9320 Always keep data inside GC objects in...

Wasmtime GitHub notifications bot (Sep 27 2024 at 16:43):

fitzgen opened PR #9320 from fitzgen:gc-data-little-endian to bytecodealliance:main:

We were previously using native-endian on the assumption that it wasn't observable to Wasm, but it turns out that assumption isn't true. The array.[init,new]_data instructions take a data segment and copy it into an array. The arrays are not limited to i8 arrays; they can be any non-reference type, so the endianness is visible, and Wasm requires little endian.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 27 2024 at 16:43):

fitzgen requested elliottt for a review on PR #9320.

Wasmtime GitHub notifications bot (Sep 27 2024 at 16:43):

fitzgen requested wasmtime-core-reviewers for a review on PR #9320.

Wasmtime GitHub notifications bot (Sep 27 2024 at 16:48):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 27 2024 at 16:49):

fitzgen has enabled auto merge for PR #9320.

Wasmtime GitHub notifications bot (Sep 27 2024 at 17:25):

fitzgen updated PR #9320.

Wasmtime GitHub notifications bot (Sep 27 2024 at 17:26):

fitzgen has enabled auto merge for PR #9320.

Wasmtime GitHub notifications bot (Sep 27 2024 at 18:18):

fitzgen updated PR #9320.

Wasmtime GitHub notifications bot (Sep 27 2024 at 18:43):

fitzgen merged PR #9320.

Last updated: Nov 22 2024 at 17:03 UTC