Stream: git-wasmtime

Topic: wasmtime / PR #9316 Correctly Reference `Imports` Trait o...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2024 at 14:43):

esarver opened PR #9316 from esarver:main to bytecodealliance:main:

If you have a WIT that contains a world named host, there is special behavior defined in wasmtime-wit-bindgen that adds an _ to the world name. This is used inconsistently, and causes a compiler error on the expanded code. See issue #9315 for more details.

I have also added test to the wasmtime-component-macro crate to prevent this from regressing.

This is my first contribution to this project so please let me know if you need any additional information or changes.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2024 at 14:43):

esarver requested fitzgen for a review on PR #9316.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2024 at 14:43):

esarver requested wasmtime-core-reviewers for a review on PR #9316.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 15:37):

alexcrichton submitted PR review:

Thank you for this, and for the test!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 15:39):

esarver commented on PR #9316:

My pleasure! Happy to help! I love what this project is doing and have been looking for a reason to use it! Finally had a chance.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2024 at 15:58):

alexcrichton merged PR #9316.

Last updated: Nov 22 2024 at 16:03 UTC