Stream: git-wasmtime

Topic: wasmtime / PR #9314 Remove module field from wasmtime::ru...

Wasmtime GitHub notifications bot (Sep 25 2024 at 19:14):

Tirthnp opened PR #9314 from Tirthnp:Change_ConstEvalContext to bytecodealliance:main:

Remove module field from wasmtime::runtime::vm::const_expr::ConstEval…
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 25 2024 at 19:17):

Tirthnp edited PR #9314:

Remove module field from wasmtime::runtime::vm::const_expr::ConstEvalContext

issue #9311
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 25 2024 at 19:17):

Tirthnp edited PR #9314:

Remove module field from wasmtime::runtime::vm::const_expr::ConstEvalContext
issue #9311
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 27 2024 at 06:01):

fitzgen submitted PR review:

Thanks a bunch!

Wasmtime GitHub notifications bot (Sep 27 2024 at 06:02):

fitzgen commented on PR #9314:

Looks like this needs a

cargo fmt

before CI will pass

Wasmtime GitHub notifications bot (Sep 27 2024 at 13:28):

Tirthnp updated PR #9314.

Wasmtime GitHub notifications bot (Sep 27 2024 at 13:30):

Tirthnp has marked PR #9314 as ready for review.

Wasmtime GitHub notifications bot (Sep 27 2024 at 13:30):

Tirthnp requested alexcrichton for a review on PR #9314.

Wasmtime GitHub notifications bot (Sep 27 2024 at 13:30):

Tirthnp requested wasmtime-core-reviewers for a review on PR #9314.

Wasmtime GitHub notifications bot (Sep 28 2024 at 15:58):

alexcrichton merged PR #9314.

Last updated: Nov 22 2024 at 16:03 UTC