Wasmtime GitHub notifications bot (Sep 25 2024 at 19:03): Wasmtime GitHub notifications bot (Sep 25 2024 at 19:03):alexcrichton opened PR #9313 from alexcrichton:remove-cranelift-wasm to bytecodealliance:main:
This commit removes the
cranelift-wasmcrate by folding it directly into thewasmtime-craneliftcrate. Maintaining a runtime-agnostic translation of WebAssembly to Cranelift has always been a bit of a burden on us and at this time there are no known users of this crate who are helping us to maintain this crate. There's a good number of abstractions in the crate purely for supporting alternative runtimes and the crate could be much simpler with far less boilerplate if it were specialized to Wasmtime.This commit purely moves the crate sources, deletes then-dead code, and updates
usepaths to all point to the right place. Otherwise this does not actually yet contain any refactoring to specialize the translation phase to Wasmtime itself. It's expected that will come in follow-up commits should we decide to merge this.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 25 2024 at 19:03):alexcrichton requested fitzgen for a review on PR #9313.
Wasmtime GitHub notifications bot (Sep 25 2024 at 19:03):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9313.
Wasmtime GitHub notifications bot (Sep 25 2024 at 19:03):alexcrichton requested wasmtime-core-reviewers for a review on PR #9313.
Wasmtime GitHub notifications bot (Sep 25 2024 at 19:03):alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #9313.
Wasmtime GitHub notifications bot (Sep 25 2024 at 19:03):alexcrichton requested wasmtime-default-reviewers for a review on PR #9313.
Wasmtime GitHub notifications bot (Sep 25 2024 at 19:21):alexcrichton updated PR #9313.
Wasmtime GitHub notifications bot (Sep 25 2024 at 19:39):fitzgen submitted PR review:
:tada:
Wasmtime GitHub notifications bot (Sep 25 2024 at 21:44):github-actions[bot] commented on PR #9313:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:docs", "cranelift:wasm", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Sep 30 2024 at 19:50):alexcrichton updated PR #9313.
Wasmtime GitHub notifications bot (Sep 30 2024 at 19:50):alexcrichton has enabled auto merge for PR #9313.
Wasmtime GitHub notifications bot (Sep 30 2024 at 19:56):alexcrichton updated PR #9313.
Wasmtime GitHub notifications bot (Sep 30 2024 at 20:22):alexcrichton merged PR #9313.
Last updated: Nov 22 2024 at 17:03 UTC