Stream: git-wasmtime

Topic: wasmtime / PR #9302 Add `-Wasync-stack-size`, automatical...

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:36):

alexcrichton opened PR #9302 from alexcrichton:increase-wasm-stack-size to bytecodealliance:main:

Recently the wasmtime CLI switched from sync to async to handle interrupting host APIs in WASI. Previously the CLI provided no means to configure the async stack size, however, which now means that when increasing the max wasm stack the CLI prints an error that cannot be resolved about the wasm stack being larger than the async stack. This commit fixes this issue by both adding a configuration option for the async stack size and additionally automatically increasing the async stack size when only the wasm stack size is provided.

Closes #9298

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:36):

alexcrichton requested fitzgen for a review on PR #9302.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:36):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9302.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:36):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9302.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:37):

alexcrichton commented on PR #9302:

I also think this'd make a good candidate for a 25.0.1 release since otherwise -Wmax-wasm-stack is a little broken right now.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:52):

alexcrichton updated PR #9302.

Wasmtime GitHub notifications bot (Sep 24 2024 at 18:45):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Sep 24 2024 at 20:28):

alexcrichton merged PR #9302.

Last updated: Nov 22 2024 at 16:03 UTC