Stream: git-wasmtime

Topic: wasmtime / PR #9301 Add the `ArrayOutOfBounds` trap code

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:30):

fitzgen opened PR #9301 from fitzgen:array-oob-trap-code to bytecodealliance:main:

This is needed in the implementation of Wasm GC's array instructions.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:30):

fitzgen requested abrown for a review on PR #9301.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:30):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9301.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:30):

fitzgen requested elliottt for a review on PR #9301.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:30):

fitzgen requested wasmtime-core-reviewers for a review on PR #9301.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:38):

alexcrichton submitted PR review:

Musing about this, we may actually want to one day not have the exact list of traps in Cranelift match the exact list of traps in Wasmtime. We might want to define Cranelift trap codes are "simply a u8" which might be much more flexible for Wasmtime as well since we wouldn't have to mirror everything in two locations. No need to do that now though, just a future possibility.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:51):

fitzgen commented on PR #9301:

We'd have to figure out what to do about how they are packed into MemFlags. Might be worth taking flags out into a secondary map or something.

Wasmtime GitHub notifications bot (Sep 24 2024 at 17:53):

alexcrichton commented on PR #9301:

Oh MemFlags should be able to easily fit 8 bits. Custom user traps in Cranelift right now though are 16 bits and that we can't fit the whole width into MemFlags

Wasmtime GitHub notifications bot (Sep 24 2024 at 18:10):

fitzgen merged PR #9301.

Last updated: Dec 23 2024 at 12:05 UTC