Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32): Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):fitzgen requested wasmtime-compiler-reviewers for a review on PR #9299.
Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):fitzgen requested elliottt for a review on PR #9299.
Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):fitzgen requested wasmtime-core-reviewers for a review on PR #9299.
Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):fitzgen opened PR #9299 from fitzgen:no-null-i31-trap-code to bytecodealliance:main:
To precisely match the Wasm spec tests, we would also need
NullStructRefandNullArrayRef, etc... This is not practical, given the encoding space we have available. We are already matching expected "null FOO reference" trap messages when running the spec tests to our own "null reference" messages, so we can do that fori31s as well.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 24 2024 at 16:56):alexcrichton submitted PR review:
We've got a fair number of bits fre in
MemFlagsso it's in theory not too hard to support more trap codes there, but I also think this is fine to have less specific traps for now and we can always refactor later if necessary
Wasmtime GitHub notifications bot (Sep 24 2024 at 17:23):fitzgen merged PR #9299.
Last updated: Nov 22 2024 at 16:03 UTC