Stream: git-wasmtime

Topic: wasmtime / PR #9299 Remove the `NullI31Ref` trap code


view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9299.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):

fitzgen requested elliottt for a review on PR #9299.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):

fitzgen requested wasmtime-core-reviewers for a review on PR #9299.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2024 at 15:32):

fitzgen opened PR #9299 from fitzgen:no-null-i31-trap-code to bytecodealliance:main:

To precisely match the Wasm spec tests, we would also need NullStructRef and NullArrayRef, etc... This is not practical, given the encoding space we have available. We are already matching expected "null FOO reference" trap messages when running the spec tests to our own "null reference" messages, so we can do that for i31s as well.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2024 at 16:56):

alexcrichton submitted PR review:

We've got a fair number of bits fre in MemFlags so it's in theory not too hard to support more trap codes there, but I also think this is fine to have less specific traps for now and we can always refactor later if necessary

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2024 at 17:23):

fitzgen merged PR #9299.


Last updated: Dec 23 2024 at 12:05 UTC