Wasmtime GitHub notifications bot (Sep 20 2024 at 21:13): Wasmtime GitHub notifications bot (Sep 20 2024 at 21:13):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9292.
Wasmtime GitHub notifications bot (Sep 20 2024 at 21:13):saulecabrera opened PR #9292 from saulecabrera:winch-x64-derive-operand-size-for-0 to bytecodealliance:main:
This commit derives the operand size from
ABI::word_bytes()in order to zero the given register rather than hardcoding it as a 32-bit size operand.The motivation for this commit is mainly avoiding hardcoding operand sizes in Winch's emission layer where possible, especially in the MacroAssembler.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 20 2024 at 21:13):saulecabrera requested cfallin for a review on PR #9292.
Wasmtime GitHub notifications bot (Sep 20 2024 at 21:13):saulecabrera requested fitzgen for a review on PR #9292.
Wasmtime GitHub notifications bot (Sep 20 2024 at 21:13):saulecabrera requested wasmtime-core-reviewers for a review on PR #9292.
Wasmtime GitHub notifications bot (Sep 20 2024 at 23:27):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Sep 20 2024 at 23:43):fitzgen merged PR #9292.
Last updated: Nov 22 2024 at 16:03 UTC