fitzgen requested wasmtime-core-reviewers for a review on PR #9282.
fitzgen requested elliottt for a review on PR #9282.
fitzgen opened PR #9282 from fitzgen:gc-struct-new-const-expr
to bytecodealliance:main
:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton submitted PR review.
alexcrichton created PR review comment:
This has me thinking, isn't rooting a problem for the entire duration of the const eval? For example we've just got these
ValRaw::anyref
values floating around internally on the const eval stack, so if a GC were to happen inStructRef::_new
above, for example, it wouldn't be able to find those roots?Should
AutoAssertNoGc
be wrapped around the entire const eval operation?
fitzgen created PR review comment:
Ah good catch, yeah
fitzgen submitted PR review.
fitzgen updated PR #9282.
alexcrichton submitted PR review.
fitzgen has enabled auto merge for PR #9282.
fitzgen updated PR #9282.
fitzgen requested wasmtime-compiler-reviewers for a review on PR #9282.
alexcrichton submitted PR review.
alexcrichton has enabled auto merge for PR #9282.
alexcrichton merged PR #9282.
Last updated: Dec 23 2024 at 13:07 UTC