Stream: git-wasmtime

Topic: wasmtime / PR #9282 Add constant evaluation support for t...

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:12):

fitzgen requested wasmtime-core-reviewers for a review on PR #9282.

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:12):

fitzgen requested elliottt for a review on PR #9282.

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:12):

fitzgen opened PR #9282 from fitzgen:gc-struct-new-const-expr to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:23):

alexcrichton created PR review comment:

This has me thinking, isn't rooting a problem for the entire duration of the const eval? For example we've just got these ValRaw::anyref values floating around internally on the const eval stack, so if a GC were to happen in StructRef::_new above, for example, it wouldn't be able to find those roots?

Should AutoAssertNoGc be wrapped around the entire const eval operation?

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:28):

fitzgen created PR review comment:

Ah good catch, yeah

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:28):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:45):

fitzgen updated PR #9282.

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:51):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 19 2024 at 16:52):

fitzgen has enabled auto merge for PR #9282.

Wasmtime GitHub notifications bot (Sep 19 2024 at 17:55):

fitzgen updated PR #9282.

Wasmtime GitHub notifications bot (Sep 19 2024 at 17:55):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9282.

Wasmtime GitHub notifications bot (Sep 19 2024 at 17:57):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 19 2024 at 17:57):

alexcrichton has enabled auto merge for PR #9282.

Wasmtime GitHub notifications bot (Sep 19 2024 at 18:21):

alexcrichton merged PR #9282.

Last updated: Oct 23 2024 at 20:03 UTC