Wasmtime GitHub notifications bot (Sep 19 2024 at 13:21): Wasmtime GitHub notifications bot (Sep 19 2024 at 13:21):bjorn3 requested fitzgen for a review on PR #9281.
Wasmtime GitHub notifications bot (Sep 19 2024 at 13:21):bjorn3 opened PR #9281 from bjorn3:deprecate_compile_and_emit to bytecodealliance:main:
The only thing it does over Context::compile is writing the machine code to a Vec specified by the user. Every user of Context::compile_and_emit in Cranelift didn't actually need ownership over the machine code bytes and thus would have been able to use Context::compile instead to avoid an unnecessary allocation. This commit moves all in-tree users of compile_and_emit to compile and additionally to avoid other users adding an unnecessary allocation as they though it to be necessary, this commit additionally deprecates compile_and_emit.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 19 2024 at 13:21):bjorn3 requested wasmtime-compiler-reviewers for a review on PR #9281.
Wasmtime GitHub notifications bot (Sep 19 2024 at 13:32):bjorn3 requested wasmtime-core-reviewers for a review on PR #9281.
Wasmtime GitHub notifications bot (Sep 19 2024 at 13:32):bjorn3 updated PR #9281.
Wasmtime GitHub notifications bot (Sep 19 2024 at 13:34):bjorn3 updated PR #9281.
Wasmtime GitHub notifications bot (Sep 19 2024 at 15:17):fitzgen submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Sep 19 2024 at 15:33):fitzgen merged PR #9281.
Last updated: Oct 23 2024 at 20:03 UTC