wasmtime / PR #9274 Use `NonNull<u8>` for `pc` instead of... · git-wasmtime

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "pulley"

Thus the following users have been cc'd because of the following labels:

fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 18 2024 at 15:08):

alexcrichton commented on PR #9274:

We're unfortunately held back on Rust versions by OSS-Fuzz right now (see https://github.com/bytecodealliance/wasmtime/pull/9231 for a bit more info), so it might be best to go ahead and get this working on our current 1.78 MSRV. I think it may just require a few more accessor methods in a few places? (e.g. .as_ptr().read() instead of .read())

Wasmtime GitHub notifications bot (Sep 19 2024 at 17:50):

Kmeakin commented on PR #9274:

We're unfortunately held back on Rust versions by OSS-Fuzz right now (see #9231 for a bit more info), so it might be best to go ahead and get this working on our current 1.78 MSRV. I think it may just require a few more accessor methods in a few places? (e.g. .as_ptr().read() instead of .read())

Should pass on 1.78 rust with the newest patch

Wasmtime GitHub notifications bot (Sep 19 2024 at 17:56):

alexcrichton commented on PR #9274:

Oh oops sorry I think I missed the update

Wasmtime GitHub notifications bot (Sep 19 2024 at 18:13):

alexcrichton merged PR #9274.

Last updated: Dec 23 2024 at 12:05 UTC