Wasmtime GitHub notifications bot (Sep 17 2024 at 19:15): Wasmtime GitHub notifications bot (Sep 17 2024 at 19:15):bjorn3 requested fitzgen for a review on PR #9267.
Wasmtime GitHub notifications bot (Sep 17 2024 at 19:15):bjorn3 requested wasmtime-compiler-reviewers for a review on PR #9267.
Wasmtime GitHub notifications bot (Sep 17 2024 at 19:15):bjorn3 opened PR #9267 from bjorn3:abi_cleanup3 to bytecodealliance:main:
The first commit adds a couple of assertions against misuse of StructReturn. The next two commits are minor cleanups. And the last commit is a partial ABI fix for multi-value returns.
Helps with https://github.com/bytecodealliance/wasmtime/issues/9250
Wasmtime GitHub notifications bot (Sep 17 2024 at 19:45):fitzgen requested cfallin for a review on PR #9267.
Wasmtime GitHub notifications bot (Sep 17 2024 at 19:45):fitzgen commented on PR #9267:
Redirecting cause I'm a bit stretched thin right now and I saw y'all were discussing this stuff on Zulip.
Wasmtime GitHub notifications bot (Sep 17 2024 at 21:13):cfallin submitted PR review:
These refactors look reasonable -- thanks for working on this!
Wasmtime GitHub notifications bot (Sep 18 2024 at 10:31):bjorn3 updated PR #9267.
Wasmtime GitHub notifications bot (Sep 18 2024 at 10:32):Fixed the bug with windows_fastcall and added a couple of Debug impl improvements.
Wasmtime GitHub notifications bot (Sep 18 2024 at 15:26):alexcrichton merged PR #9267.
Last updated: Dec 23 2024 at 12:05 UTC