Stream: git-wasmtime

Topic: wasmtime / PR #9262 wit-bindgen: Don't trace values conta...

Wasmtime GitHub notifications bot (Sep 16 2024 at 23:35):

sunfishcode opened PR #9262 from sunfishcode:sunfishcode/verbose-tracing to bytecodealliance:main:

list values in Wit interfaces can represent things like HTTP bodies which can be very large. To enable tracing without spamming logfiles with all this data, put printing of values containing lists behind a separate verbose_tracing option.

This is a coarse-grained approach; but it seems like a pretty good default for tracing, and enabling full tracing when one needs it is straightforward.

In the future, we may want to refine the option by implementing the Valuable trait and using tracing::field::valuable, which could allow us to do things like print non-list fields of records that otherwise contain lists.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 16 2024 at 23:35):

sunfishcode requested fitzgen for a review on PR #9262.

Wasmtime GitHub notifications bot (Sep 16 2024 at 23:35):

sunfishcode requested wasmtime-core-reviewers for a review on PR #9262.

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:20):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:20):

alexcrichton created PR review comment:

This might be a good use case for the option_type_contains_lists helper? (and perhaps stream below?)

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:20):

alexcrichton created PR review comment:

Mind hooking this up as well to the macro input?

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:39):

sunfishcode updated PR #9262.

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:39):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:39):

sunfishcode created PR review comment:

Done!

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:39):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:39):

sunfishcode created PR review comment:

Done!

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:44):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 17 2024 at 15:44):

alexcrichton has enabled auto merge for PR #9262.

Wasmtime GitHub notifications bot (Sep 17 2024 at 17:00):

sunfishcode updated PR #9262.

Wasmtime GitHub notifications bot (Sep 17 2024 at 17:27):

alexcrichton merged PR #9262.

Last updated: Oct 23 2024 at 20:03 UTC