Stream: git-wasmtime

Topic: wasmtime / PR #9260 Stop special-casing `i31ref` accesses...

Wasmtime GitHub notifications bot (Sep 16 2024 at 19:17):

fitzgen opened PR #9260 from fitzgen:stop-special-casing-i31ref to bytecodealliance:main:

Consolidate all i31ref special casing into the translate_{read,write}_gc_reference methods, which already emit more or less inline GC barriers depending on the reference's heap type, so it makes sense to also handle i31ref there.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 16 2024 at 19:17):

fitzgen requested pchickey for a review on PR #9260.

Wasmtime GitHub notifications bot (Sep 16 2024 at 19:17):

fitzgen requested wasmtime-core-reviewers for a review on PR #9260.

Wasmtime GitHub notifications bot (Sep 16 2024 at 19:17):

fitzgen commented on PR #9260:

Thought I landed this on Friday, but I guess not.

Wasmtime GitHub notifications bot (Sep 16 2024 at 19:17):

fitzgen requested alexcrichton for a review on PR #9260.

Wasmtime GitHub notifications bot (Sep 16 2024 at 19:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 16 2024 at 19:44):

alexcrichton merged PR #9260.

Last updated: Dec 23 2024 at 12:05 UTC