Wasmtime GitHub notifications bot (Sep 16 2024 at 11:52): Wasmtime GitHub notifications bot (Sep 16 2024 at 11:52):bjorn3 opened PR #9253 from bjorn3:abi_cleanup to bytecodealliance:main:
This also removes the
WasmtimeSystemVcall conv as it is no longer used anywhere.
Wasmtime GitHub notifications bot (Sep 16 2024 at 11:52):bjorn3 requested abrown for a review on PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 11:52):bjorn3 requested wasmtime-compiler-reviewers for a review on PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 11:56):bjorn3 updated PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 11:57):bjorn3 updated PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 13:12):bjorn3 updated PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 13:13):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Sep 16 2024 at 13:13):bjorn3 created PR review comment:
@uweigand should CallConv::Winch be LittleEndian too?
Wasmtime GitHub notifications bot (Sep 16 2024 at 13:37):uweigand submitted PR review.
Wasmtime GitHub notifications bot (Sep 16 2024 at 13:37):uweigand created PR review comment:
We don't support Winch at all on s390x right now, so this probably doesn't matter at this point. If and when we ever add support for Winch, we can re-think this, based on what the actual use case would be.
Wasmtime GitHub notifications bot (Sep 16 2024 at 14:44):github-actions[bot] commented on PR #9253:
Subscribe to Label Action
cc @cfallin, @fitzgen, @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "cranelift:docs", "isle", "winch"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Sep 16 2024 at 14:50):bjorn3 updated PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 15:04):bjorn3 updated PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 15:36):alexcrichton submitted PR review:
Thanks for this!
Wasmtime GitHub notifications bot (Sep 16 2024 at 15:55):uweigand submitted PR review.
Wasmtime GitHub notifications bot (Sep 16 2024 at 15:55):uweigand created PR review comment:
Not sure I understand the point of this change. This now increments next_gpr always, even when get_intreg_for_arg returns None, i.e. no GPR is actually used. This is only correct under the implicit assumption that if get_intreg_for_arg failed once, it will always fail in the future. That may be true with the current ABI, but not necessarily with any possible future ABIs ...
Wasmtime GitHub notifications bot (Sep 16 2024 at 16:00):alexcrichton commented on PR #9253:
(removed from the merge queue for Ulrich's comment)
Wasmtime GitHub notifications bot (Sep 16 2024 at 16:06):bjorn3 updated PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 16:10):bjorn3 created PR review comment:
This matches the x86_64 backend, but turns out the other backends do it similar to s390x. In any case I've reverted this commit.
Wasmtime GitHub notifications bot (Sep 16 2024 at 16:10):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Sep 16 2024 at 16:14):alexcrichton has enabled auto merge for PR #9253.
Wasmtime GitHub notifications bot (Sep 16 2024 at 16:36):alexcrichton merged PR #9253.
Last updated: Nov 22 2024 at 16:03 UTC