Stream: git-wasmtime

Topic: wasmtime / PR #9252 Winch aarch64 dynamic heap


view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 09:20):

vulc41n requested wasmtime-compiler-reviewers for a review on PR #9252.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 09:20):

vulc41n requested elliottt for a review on PR #9252.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 09:20):

vulc41n requested wasmtime-core-reviewers for a review on PR #9252.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 09:20):

vulc41n opened PR #9252 from vulc41n:winch-aarch64-dyn-heap to bytecodealliance:main:

Hey :wave:

This PR implements everything needed to run winch for aarch64 with dynamic heap. It implements the following macro instructions : trap, trapif, cmov and checked_add.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 11:44):

github-actions[bot] commented on PR #9252:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 15:39):

saulecabrera submitted PR review:

Thanks. Left some comments which we should address/clarify.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 15:39):

saulecabrera created PR review comment:

I believe here we'd want to use Cond::Hs? The Cond::Vs is for signed overflow. (Ref: https://developer.arm.com/documentation/dui0801/l/Condition-Codes/Carry-flag)

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 15:39):

saulecabrera created PR review comment:

I think it'd be better to handle this instruction via csel. Any particular reason you decided to go this route?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2024 at 12:20):

vulc41n submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2024 at 12:20):

vulc41n created PR review comment:

You're right, I didn't think about it

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2024 at 12:29):

vulc41n updated PR #9252.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2024 at 16:20):

saulecabrera submitted PR review:

LGTM, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 20 2024 at 16:48):

saulecabrera commented on PR #9252:

@vulc41n it looks like an update to the filetests is needed?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 19:12):

saulecabrera updated PR #9252.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 19:15):

saulecabrera commented on PR #9252:

@vulc41n filetests were correct, it needed a rebase. I took the liberty to do the rebase so that we can go ahead and land this PR.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 04 2024 at 19:43):

saulecabrera merged PR #9252.


Last updated: Dec 23 2024 at 12:05 UTC