alexcrichton requested fitzgen for a review on PR #9248.
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9248.
alexcrichton opened PR #9248 from alexcrichton:x64-mulx
to bytecodealliance:main
:
This commit adds backend support for the
mulx
instruction in the BMI2 instruction set which supports arbitrary destination registers. This instruction also doesn't read/clobber flags so it can help pipeline instructions in niche situations.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen submitted PR review.
fitzgen created PR review comment:
Is there no
imulx
instruction for signed multiplication?
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Alas not that I can find, just an unsigned variant. I think it's geared towards bignum libraries where most of the intermediate ops are unsigned ones.
alexcrichton has enabled auto merge for PR #9248.
fitzgen submitted PR review.
fitzgen created PR review comment:
Makes sense, thanks for checking
alexcrichton merged PR #9248.
Last updated: Dec 23 2024 at 12:05 UTC