Stream: git-wasmtime

Topic: wasmtime / PR #9248 x64: Add support for the BMI2 `mulx` ...

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:45):

alexcrichton requested fitzgen for a review on PR #9248.

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:45):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9248.

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:45):

alexcrichton opened PR #9248 from alexcrichton:x64-mulx to bytecodealliance:main:

This commit adds backend support for the mulx instruction in the BMI2 instruction set which supports arbitrary destination registers. This instruction also doesn't read/clobber flags so it can help pipeline instructions in niche situations.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:50):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:50):

fitzgen created PR review comment:

Is there no imulx instruction for signed multiplication?

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:56):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:56):

alexcrichton created PR review comment:

Alas not that I can find, just an unsigned variant. I think it's geared towards bignum libraries where most of the intermediate ops are unsigned ones.

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:56):

alexcrichton has enabled auto merge for PR #9248.

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:59):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2024 at 21:59):

fitzgen created PR review comment:

Makes sense, thanks for checking

Wasmtime GitHub notifications bot (Sep 13 2024 at 22:15):

alexcrichton merged PR #9248.

Last updated: Nov 22 2024 at 16:03 UTC