Wasmtime GitHub notifications bot (Sep 13 2024 at 15:25): Wasmtime GitHub notifications bot (Sep 13 2024 at 15:25):fitzgen opened PR #9240 from fitzgen:wasmtime-compile-pulley to bytecodealliance:main:
This does not yet add support for running Wasm modules compiled with Pulley, but it does allow compiling them via
wasmtime compile. This is a first step towards integrating Pulley into Wasmtime itself.This is also enough to get basic
tests/disastests working with Pulley.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:25):fitzgen requested pchickey for a review on PR #9240.
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:25):fitzgen requested wasmtime-core-reviewers for a review on PR #9240.
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:25):fitzgen requested wasmtime-default-reviewers for a review on PR #9240.
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:25):fitzgen requested alexcrichton for a review on PR #9240.
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:41):fitzgen updated PR #9240.
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:48):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:48):alexcrichton created PR review comment:
Perhaps
disas_insnsto drop the "elf" bit?
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:48):alexcrichton created PR review comment:
Mind switching this to something like
struct Instr { /* named fields here */ }?
Wasmtime GitHub notifications bot (Sep 13 2024 at 15:48):alexcrichton created PR review comment:
Do you think it's worth having for example an extension trait on
TargetTriplefor.is_pulley()to use here and in wasmtime-environ as well? Not that this set of architectures is going to change over time really
Wasmtime GitHub notifications bot (Sep 13 2024 at 16:07):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Sep 13 2024 at 16:07):fitzgen created PR review comment:
Good idea, will do in a follow up
Wasmtime GitHub notifications bot (Sep 13 2024 at 16:07):fitzgen updated PR #9240.
Wasmtime GitHub notifications bot (Sep 13 2024 at 16:07):fitzgen has enabled auto merge for PR #9240.
Wasmtime GitHub notifications bot (Sep 13 2024 at 16:35):fitzgen merged PR #9240.
Last updated: Dec 23 2024 at 12:05 UTC