Wasmtime GitHub notifications bot (Sep 11 2024 at 13:38): Wasmtime GitHub notifications bot (Sep 11 2024 at 13:38):rockwotj requested wasmtime-core-reviewers for a review on PR #9224.
Wasmtime GitHub notifications bot (Sep 11 2024 at 13:38):rockwotj opened PR #9224 from rockwotj:patch-2 to bytecodealliance:main:
See the comment in the source file, we can't have FORTIFY_SOURCE enabled for longjmp code, so undefine it.
See the source for longjmp_chk in glibc, this assertion is fired: https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/____longjmp_chk.c;hb=HEAD#l54
Here is a similar commit in glibc tests: https://sourceware.org/git/?p=glibc.git;a=commit;h=46432be2f1d4de962b51ca6b9f80fc37744be9f7
We're only hitting this now because we're properly propagating our C/C++ compiler flags to the C code that Wasmtime's build scripts are running.
Wasmtime GitHub notifications bot (Sep 11 2024 at 13:38):rockwotj requested alexcrichton for a review on PR #9224.
Wasmtime GitHub notifications bot (Sep 11 2024 at 13:53):rockwotj updated PR #9224.
Wasmtime GitHub notifications bot (Sep 11 2024 at 13:57):rockwotj edited PR #9224:
See the comment in the source file, we can't have FORTIFY_SOURCE enabled for longjmp code, so undefine it.
See the source for longjmp_chk in glibc, this assertion is fired: https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/____longjmp_chk.c;hb=HEAD#l54
Here is a similar commit in glibc tests: https://sourceware.org/git/?p=glibc.git;a=commit;h=46432be2f1d4de962b51ca6b9f80fc37744be9f7
We're only hitting this now because we're properly propagating our C/C++ compiler flags to the C code that Wasmtime's build scripts are compiling.
Wasmtime GitHub notifications bot (Sep 11 2024 at 14:48):alexcrichton submitted PR review:
Thanks for this!
Wasmtime GitHub notifications bot (Sep 11 2024 at 15:04):alexcrichton merged PR #9224.
Last updated: Nov 22 2024 at 16:03 UTC