Wasmtime GitHub notifications bot (Sep 10 2024 at 20:34): Wasmtime GitHub notifications bot (Sep 10 2024 at 20:34):alexcrichton requested pchickey for a review on PR #9223.
Wasmtime GitHub notifications bot (Sep 10 2024 at 20:34):alexcrichton requested wasmtime-core-reviewers for a review on PR #9223.
Wasmtime GitHub notifications bot (Sep 10 2024 at 20:34):alexcrichton opened PR #9223 from alexcrichton:implement-more-wast to bytecodealliance:main:
This is a follow-up from #9219 to add support for a few more directives in
*.wasttests to notably compile a module and possibly instantiate it multiple times.This copies the upstream spec test using these new directives and edits it to remove the unsupported exception-handling bits.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 10 2024 at 20:52):pchickey commented on PR #9223:
Looks good, but the component paths aren't exercised in the tests. Is there missing functionality where those can't be exercised yet, or can we add a test for it?
Wasmtime GitHub notifications bot (Sep 10 2024 at 21:18):alexcrichton updated PR #9223.
Wasmtime GitHub notifications bot (Sep 10 2024 at 21:18):alexcrichton commented on PR #9223:
Good point! I've added a small test for components too
Wasmtime GitHub notifications bot (Sep 10 2024 at 21:54):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Sep 10 2024 at 22:10):pchickey merged PR #9223.
Last updated: Oct 23 2024 at 20:03 UTC