Stream: git-wasmtime

Topic: wasmtime / PR #9213 #7954 alias analysis attempt

Wasmtime GitHub notifications bot (Sep 07 2024 at 20:24):

badumbatish opened PR #9213 from badumbatish:7954 to bytecodealliance:main:

Mentioned in #7954, attempted in #8535, reattempted in this pr.

Draft first for ci pipeline. Possible rebase for better commit msg

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 07 2024 at 20:57):

badumbatish updated PR #9213.

Wasmtime GitHub notifications bot (Sep 07 2024 at 21:09):

badumbatish has marked PR #9213 as ready for review.

Wasmtime GitHub notifications bot (Sep 07 2024 at 21:09):

badumbatish requested elliottt for a review on PR #9213.

Wasmtime GitHub notifications bot (Sep 07 2024 at 21:09):

badumbatish requested wasmtime-compiler-reviewers for a review on PR #9213.

Wasmtime GitHub notifications bot (Sep 17 2024 at 16:04):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Sep 17 2024 at 16:04):

elliottt created PR review comment:

Is this function still needed? It doesn't look like it's referenced from the changes in this PR.

Wasmtime GitHub notifications bot (Sep 22 2024 at 20:55):

badumbatish updated PR #9213.

Wasmtime GitHub notifications bot (Sep 22 2024 at 20:57):

badumbatish submitted PR review.

Wasmtime GitHub notifications bot (Sep 22 2024 at 20:57):

badumbatish created PR review comment:

hi there :) I double checked and it seems nothing is calling this function. I've removed it. Thank you for the review :)

Wasmtime GitHub notifications bot (Sep 25 2024 at 20:50):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Sep 25 2024 at 20:50):

elliottt created PR review comment:

Could you rephrase this comment from Jamey as a comment about the function implementation?

Wasmtime GitHub notifications bot (Sep 25 2024 at 20:50):

elliottt created PR review comment:

Does the test suite pass with these assertions uncommented? You're testing nb explicitly for being unreachable on line 491, so I'm guessing that at least that one doesn't pass?

Wasmtime GitHub notifications bot (Sep 26 2024 at 20:11):

badumbatish submitted PR review.

Wasmtime GitHub notifications bot (Sep 26 2024 at 20:11):

badumbatish created PR review comment:

hi Elliot, yes one of the test suite failed with this assertion. Here is the summary of the test suite through local ci:

failures:

---- dominator_tree::tests::unreachable_node stdout ----
thread 'dominator_tree::tests::unreachable_node' panicked at cranelift/codegen/src/dominator_tree.rs:486:9:
assertion failed: nb.pre_number != 0


failures:
    dominator_tree::tests::unreachable_node

test result: FAILED. 187 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.21s

error: test failed, to rerun pass `-p cranelift-codegen --lib`

Wasmtime GitHub notifications bot (Sep 26 2024 at 20:13):

badumbatish edited PR review comment.

Wasmtime GitHub notifications bot (Sep 26 2024 at 20:19):

badumbatish updated PR #9213.

Wasmtime GitHub notifications bot (Sep 26 2024 at 20:19):

badumbatish submitted PR review.

Wasmtime GitHub notifications bot (Sep 26 2024 at 20:19):

badumbatish created PR review comment:

resolved

Last updated: Nov 22 2024 at 16:03 UTC