Stream: git-wasmtime

Topic: wasmtime / PR #9208 [wasi-http] Return `none` from `futur...

Wasmtime GitHub notifications bot (Sep 06 2024 at 16:55):

dicej requested elliottt for a review on PR #9208.

Wasmtime GitHub notifications bot (Sep 06 2024 at 16:55):

dicej opened PR #9208 from dicej:wasi-http-trailers to bytecodealliance:main:

Previously, we would return error-code::connection-terminated in this case, whereas the wasi-http spec says we should simply return none (i.e. it's not an error if there are no trailers present).

This also adds code to api_proxy_streaming.rs to check for trailers after reading the body content.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 06 2024 at 16:55):

dicej requested wasmtime-core-reviewers for a review on PR #9208.

Wasmtime GitHub notifications bot (Sep 06 2024 at 17:05):

dicej updated PR #9208.

Wasmtime GitHub notifications bot (Sep 06 2024 at 19:13):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 06 2024 at 19:13):

alexcrichton commented on PR #9208:

Thanks!

Wasmtime GitHub notifications bot (Sep 06 2024 at 19:28):

alexcrichton merged PR #9208.

Last updated: Oct 23 2024 at 20:03 UTC