Wasmtime GitHub notifications bot (Aug 30 2024 at 23:20): Wasmtime GitHub notifications bot (Aug 30 2024 at 23:20):elliottt requested cfallin for a review on PR #9193.
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:20):elliottt requested fitzgen for a review on PR #9193.
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:20):elliottt requested alexcrichton for a review on PR #9193.
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:20):elliottt opened PR #9193 from bytecodealliance:revert-9191-trevor/upgrade-regalloc to bytecodealliance:main:
Reverts bytecodealliance/wasmtime#9191
We need to yank regalloc-0.9.4 and bump it to 0.10.0, as a function was removed in 0.9.4.
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:20):elliottt requested wasmtime-default-reviewers for a review on PR #9193.
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:20):elliottt requested wasmtime-compiler-reviewers for a review on PR #9193.
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:21):alexcrichton commented on PR #9193:
Oh I think this is fine to leave in wasmtime, yanks don't delete the crate it just prevents new dependencies being formed on the crate. In that sense if you yank regalloc2 now then wasmtime will keep building. In that sense this shouldn't be necessary
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:26):elliottt closed without merge PR #9193.
Wasmtime GitHub notifications bot (Aug 30 2024 at 23:26):elliottt commented on PR #9193:
Ah, I misunderstood what the effect of yanking the crate was. I'll close the revert :+1:
Wasmtime GitHub notifications bot (Aug 31 2024 at 08:42):If anyone tries to depend on the wasmtime version on the main branch as library, they can't if they didn't have a lockfile from before 0.9.4 got yanked and there is no regalloc2 version semver compatible with the 0.9.4 dependency requirement. If a non-yanked 0.9.5 existed, this one would be picked, but alas it doesn't exist and thus cargo will return an error.
Wasmtime GitHub notifications bot (Aug 31 2024 at 14:56):alexcrichton commented on PR #9193:
Ah that's a good point, if that's causing issues for you I can approve/merge a revert too
Wasmtime GitHub notifications bot (Aug 31 2024 at 15:16):elliottt commented on PR #9193:
Should we upload a 0.9.5 that's just a re-release of 0.9.3?
Wasmtime GitHub notifications bot (Aug 31 2024 at 15:32):elliottt reopened PR #9193.
Wasmtime GitHub notifications bot (Aug 31 2024 at 15:39):elliottt commented on PR #9193:
Let's just revert the update and restore the changes when we release regalloc2 0.10.0 with safepoint support removed next week.
Wasmtime GitHub notifications bot (Aug 31 2024 at 15:54):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 31 2024 at 16:09):alexcrichton merged PR #9193.
Last updated: Oct 23 2024 at 20:03 UTC