Wasmtime GitHub notifications bot (Aug 28 2024 at 19:03): Wasmtime GitHub notifications bot (Aug 28 2024 at 19:03):fitzgen opened PR #9180 from fitzgen:dont-dealloc-disabled-gc-heap to bytecodealliance:main:
When the reference types proposal is disabled, we don't allocate a GC heap from the instance allocator, we instead create a
DisabledGcHeap. Rather than returning this to the instance allocator when we're done with it, which won't even know what to do with it since the instance allocator didn't create the GC heap, we simply rely on theDisabledGcHeap'sDropimplementation.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 28 2024 at 19:03):fitzgen requested alexcrichton for a review on PR #9180.
Wasmtime GitHub notifications bot (Aug 28 2024 at 19:03):fitzgen requested wasmtime-core-reviewers for a review on PR #9180.
Wasmtime GitHub notifications bot (Aug 28 2024 at 19:54):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 28 2024 at 19:54):alexcrichton created PR review comment:
While you're here mind handling https://github.com/bytecodealliance/wasmtime/pull/9162 here as well and renaming
reference_typesin this PR togc_typesinstead?
Wasmtime GitHub notifications bot (Aug 28 2024 at 20:00):fitzgen updated PR #9180.
Wasmtime GitHub notifications bot (Aug 28 2024 at 20:01):fitzgen has enabled auto merge for PR #9180.
Wasmtime GitHub notifications bot (Aug 28 2024 at 20:36):fitzgen merged PR #9180.
Last updated: Nov 22 2024 at 17:03 UTC