Stream: git-wasmtime

Topic: wasmtime / PR #9177 Expand the set of constructors of `bi...

Wasmtime GitHub notifications bot (Aug 28 2024 at 14:39):

alexcrichton opened PR #9177 from alexcrichton:more-ctors to bytecodealliance:main:

This commit expands the set of supported constructors for bindgen! generated structures with the goal of bringing back World::new(&mut store, instance). This method was removed previously in a refactoring to add *Pre structures but refactoring preexisting code to use *Pre isn't always easy, so these extra generated bindings provide a smoother migration path for code from before.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 28 2024 at 14:39):

alexcrichton requested pchickey for a review on PR #9177.

Wasmtime GitHub notifications bot (Aug 28 2024 at 14:39):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9177.

Wasmtime GitHub notifications bot (Aug 28 2024 at 15:04):

alexcrichton updated PR #9177.

Wasmtime GitHub notifications bot (Aug 28 2024 at 16:11):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 28 2024 at 16:59):

alexcrichton merged PR #9177.

Last updated: Nov 22 2024 at 16:03 UTC