alexcrichton opened PR #9176 from alexcrichton:opt-i128-cmp
to bytecodealliance:main
:
This commits adds pattern-matches to detect 128-bit comparisons encoded in 64-bit comparisons and promote them to 128-bit to enable backends to apply architecture-specific optimizations to these operations.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested abrown for a review on PR #9176.
alexcrichton requested fitzgen for a review on PR #9176.
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9176.
alexcrichton requested wasmtime-core-reviewers for a review on PR #9176.
fitzgen submitted PR review.
fitzgen created PR review comment:
Can we do the same with an
sextend
?
alexcrichton updated PR #9176.
alexcrichton commented on PR #9176:
I've enabled
sextend
lifting as well now. I additionally limited this optimization to only happening for i64-to-i128-compares. While it should work for other widths current backends don't implementiconcat
for two 32-bit halves to a 64-bit integer, so I was getting codegen errors on a module.
alexcrichton has enabled auto merge for PR #9176.
alexcrichton merged PR #9176.
Last updated: Dec 23 2024 at 12:05 UTC