Stream: git-wasmtime

Topic: wasmtime / PR #9175 Expand the set of constructors of `bi...

Wasmtime GitHub notifications bot (Aug 27 2024 at 22:27):

alexcrichton opened PR #9175 from alexcrichton:more-generated-bindings to bytecodealliance:main:

This commit expands the set of supported constructors for bindgen! generated structures with the goal of bringing back World::new(&mut store, instance). This method was removed previously in a refactoring to add *Pre structures but refactoring preexisting code to use *Pre isn't always easy, so these extra generated bindings provide a smoother migration path for code from before.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 27 2024 at 22:27):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9175.

Wasmtime GitHub notifications bot (Aug 27 2024 at 22:27):

alexcrichton requested elliottt for a review on PR #9175.

Wasmtime GitHub notifications bot (Aug 28 2024 at 14:40):

alexcrichton closed without merge PR #9175.

Wasmtime GitHub notifications bot (Aug 28 2024 at 14:40):

alexcrichton commented on PR #9175:

A memory lapse had me forget that I sent this PR... I opened a duplicate with https://github.com/bytecodealliance/wasmtime/pull/9177 which has a few more minor fixes so I'm going to close in favor of that.

Last updated: Oct 23 2024 at 20:03 UTC