Spartan2909 opened PR #9173 from Spartan2909:main
to bytecodealliance:main
:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->Removes the implicit
Sized
requirement on the implementation for&mut M where M: Module
and adds an implementation forBox<dyn Module>
.
Spartan2909 requested elliottt for a review on PR #9173.
Spartan2909 requested wasmtime-compiler-reviewers for a review on PR #9173.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Is it worth generalizing this to
impl<M: Module + ?Sized> Module for Box<M>
as well?
Spartan2909 updated PR #9173.
Spartan2909 submitted PR review.
Spartan2909 created PR review comment:
Done
alexcrichton submitted PR review.
alexcrichton merged PR #9173.
Last updated: Dec 23 2024 at 13:07 UTC