Wasmtime GitHub notifications bot (Aug 27 2024 at 14:19): Wasmtime GitHub notifications bot (Aug 27 2024 at 14:19):saulecabrera requested fitzgen for a review on PR #9171.
Wasmtime GitHub notifications bot (Aug 27 2024 at 14:19):saulecabrera opened PR #9171 from saulecabrera:improve-aarch64-abi to bytecodealliance:main:
This commit introduces missing tests for Aarch64's ABI implementation. Compared to the x64 counterpart, the aarch64 implementation was missing tests for multi-value.
Additionally, this commit fixes an issue with how multi-value returns are handlded in Winch's default calling convention, which only allows 1 register result, independent of the register class.
This commit also refactors the register indexing environment so that it can be easily shared across the existing backends.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 27 2024 at 14:19):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9171.
Wasmtime GitHub notifications bot (Aug 27 2024 at 14:21):saulecabrera updated PR #9171.
Wasmtime GitHub notifications bot (Aug 27 2024 at 15:20):fitzgen submitted PR review:
Nice catch!
Wasmtime GitHub notifications bot (Aug 27 2024 at 15:34):fitzgen merged PR #9171.
Last updated: Nov 22 2024 at 17:03 UTC