Stream: git-wasmtime

Topic: wasmtime / PR #9168 Refactor how wasm features are spelle...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2024 at 15:23):

alexcrichton opened PR #9168 from alexcrichton:refactor-enabling-features-slightly to bytecodealliance:main:

Use the new WasmFeatures::wasm2() constructor to avoid having to indefinitely list old proposals where this can get updated as newer versions of the specification are released that Wasmtime fully implements. Additionally slightly refactor how conditional enabling of features work and instead use the set function to guarantee setting the requisite feature to the desired value.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2024 at 15:23):

alexcrichton requested pchickey for a review on PR #9168.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2024 at 15:23):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9168.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2024 at 17:44):

github-actions[bot] commented on PR #9168:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2024 at 23:59):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2024 at 17:10):

alexcrichton merged PR #9168.


Last updated: Dec 23 2024 at 12:05 UTC