Stream: git-wasmtime

Topic: wasmtime / PR #9164 Remove reference types (`r32` and `r6...

Wasmtime GitHub notifications bot (Aug 22 2024 at 20:51):

fitzgen opened PR #9164 from fitzgen:no-more-ref-types to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 22 2024 at 20:51):

fitzgen requested abrown for a review on PR #9164.

Wasmtime GitHub notifications bot (Aug 22 2024 at 20:51):

fitzgen requested alexcrichton for a review on PR #9164.

Wasmtime GitHub notifications bot (Aug 22 2024 at 20:51):

fitzgen requested wasmtime-core-reviewers for a review on PR #9164.

Wasmtime GitHub notifications bot (Aug 22 2024 at 20:51):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9164.

Wasmtime GitHub notifications bot (Aug 22 2024 at 20:53):

fitzgen updated PR #9164.

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:04):

cfallin submitted PR review:

(Cranelift) reftypes are dead; long life (Wasm) reftypes!

Really happy to see this simplification -- long time coming, thanks for all the work pushing it through.

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:04):

cfallin created PR review comment:

It looks like this whole test was deleted because it uses a null.r64 instruction, but the instruction isn't critical to the test (result of random fuzz generation); could we replace it with an iconst.i64 0 or somesuch and keep the test?

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:08):

cfallin submitted PR review:

(Cranelift) reftypes are dead; long live (Wasm) reftypes!

Really happy to see this simplification -- long time coming, thanks for all the work pushing it through.

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:26):

fitzgen updated PR #9164.

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:26):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:26):

fitzgen created PR review comment:

Ah, I didn't look closely and assumed it relied on the r64; added it back and updated it!

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:26):

fitzgen has enabled auto merge for PR #9164.

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:54):

fitzgen merged PR #9164.

Last updated: Dec 23 2024 at 12:05 UTC