Stream: git-wasmtime

Topic: wasmtime / PR #9162 Update the consequences of disabling ...

Wasmtime GitHub notifications bot (Aug 22 2024 at 18:08):

alexcrichton requested elliottt for a review on PR #9162.

Wasmtime GitHub notifications bot (Aug 22 2024 at 18:08):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9162.

Wasmtime GitHub notifications bot (Aug 22 2024 at 18:10):

alexcrichton opened PR #9162 from alexcrichton:update-with-gc-types-feature to bytecodealliance:main:

This commit updates what happens when the gc Cargo feature is disabled at compile time when compiling Wasmtime itself. Previously this would disable the reference-types proposal (and eventually once finished the gc/function-references proposal). This has the downside, however, of additionally disabling non-gc-related features that were bundled into the reference-types proposal such as multi-table and the encodings of table indices as LEBs in call_indirect instructions for example.

The change in this commit is to instead toggle the newly-added GC_TYPES feature in wasmparser. This feature does not correspond to upstream wasm proposals and instead only gates types such as externref or anyref. The funcref and exnref types are not gated as they're not expected to require a full GC.

This means that in Wasmtime the reference-types feature is now always active by default regardless of crate features. If the gc crate feature is disabled then only externref values are disallowed.

This additionally flags GC_TYPES as unsupported in Winch due to no support for externref yet. This means, though, that Winch can be considered as supporting the reference-types proposal (and things like multi-table) as expected. Disabling externref support switched a few tests to failing so those exceptions are now listed in tests/wast.rs

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 22 2024 at 19:06):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2024 at 19:10):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 22 2024 at 21:44):

github-actions[bot] commented on PR #9162:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Aug 22 2024 at 23:52):

alexcrichton updated PR #9162.

Wasmtime GitHub notifications bot (Aug 22 2024 at 23:52):

alexcrichton has enabled auto merge for PR #9162.

Wasmtime GitHub notifications bot (Aug 23 2024 at 14:50):

alexcrichton updated PR #9162.

Wasmtime GitHub notifications bot (Aug 23 2024 at 14:50):

alexcrichton has enabled auto merge for PR #9162.

Wasmtime GitHub notifications bot (Aug 23 2024 at 15:14):

alexcrichton merged PR #9162.

Last updated: Oct 23 2024 at 20:03 UTC