Stream: git-wasmtime

Topic: wasmtime / PR #9159 Cranelift: Remove the old stack maps ...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 22:31):

fitzgen opened PR #9159 from fitzgen:remove-old-stack-maps to bytecodealliance:main:

They are superseded by the new user stack maps implementation.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 22:31):

fitzgen requested elliottt for a review on PR #9159.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 22:31):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9159.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2024 at 00:24):

elliottt submitted PR review:

Awesome!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2024 at 15:49):

fitzgen merged PR #9159.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2024 at 19:43):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2024 at 19:43):

bjorn3 created PR review comment:

Can cranelif-tool print user stackmaps?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2024 at 19:43):

bjorn3 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2024 at 19:54):

fitzgen created PR review comment:

The vcode's debug implementation should include the stack maps:

https://github.com/bytecodealliance/wasmtime/blob/9d35545bf1227c701e37b7c35ec3018ddcdefc43/cranelift/filetests/filetests/isa/x64/user_stack_maps.clif#L55-L68

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2024 at 19:54):

fitzgen submitted PR review.


Last updated: Nov 22 2024 at 17:03 UTC