Stream: git-wasmtime

Topic: wasmtime / PR #9158 Update handling of wasm features and ...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:03):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9158.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:03):

alexcrichton requested cfallin for a review on PR #9158.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:03):

alexcrichton opened PR #9158 from alexcrichton:improve-wast-testing-and-features to bytecodealliance:main:

This commit is an attempt at making it easier to manage the set of variables we have in play with *.wast testing and wasm features. The Cranelift and Winch backends support different sets of wasm features at this time and historically Cranelift has also had architecture-specific support for wasm features. This is hoped to help simplify management of all of this in the future in addition to making *.wast testing more robust. Notable changes here are:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:03):

alexcrichton requested elliottt for a review on PR #9158.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:03):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9158.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:05):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:05):

alexcrichton created PR review comment:

cc @saulecabrera I added some bare-bones pieces for Extern in a few places in this PR to get winch as "supporting" reference-types. Flagging Winch as not supporting reference types ended up being particularly difficult because it ends up disabling nearly all tests one way or another. The goal here was to just not panic on the existence of externref, but if you prefer I can try to figure out how to detect this elsewhere and reject it while keeping these panics.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:33):

alexcrichton updated PR #9158.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 20:37):

alexcrichton updated PR #9158.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 22:44):

github-actions[bot] commented on PR #9158:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "wasmtime:api", "wasmtime:config", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 20 2024 at 22:44):

github-actions[bot] commented on PR #9158:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2024 at 11:35):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2024 at 11:35):

saulecabrera created PR review comment:

This looks good to me, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2024 at 23:07):

elliottt submitted PR review:

Awesome!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2024 at 15:17):

alexcrichton merged PR #9158.


Last updated: Dec 23 2024 at 12:05 UTC