Stream: git-wasmtime

Topic: wasmtime / PR #9150 Adding an --emit-opt-clif CLI option

Wasmtime GitHub notifications bot (Aug 20 2024 at 06:13):

dimitris-aspetakis opened PR #9150 from karouzakisp:main to bytecodealliance:main:

The option --emit-opt-clif follows the --emit-clif implementation from wasmtime's CLI, but the output comes with the egraph optimizations applied. It has been helpful for work on #6260. From discussions in zulip, it seemed more generally desirable.

• I consider some small changes in crates/cranelift/src/compiler.rs to be a bit "hacky", probably due to my inexperience with the borrow checker...
• The current state does not include support for the wasmtime explorer.

Wasmtime GitHub notifications bot (Aug 20 2024 at 06:13):

dimitris-aspetakis requested elliottt for a review on PR #9150.

Wasmtime GitHub notifications bot (Aug 20 2024 at 06:13):

dimitris-aspetakis requested wasmtime-core-reviewers for a review on PR #9150.

Wasmtime GitHub notifications bot (Aug 20 2024 at 06:22):

dimitris-aspetakis edited PR #9150:

The option --emit-opt-clif follows the --emit-clif implementation from wasmtime's CLI, but the output comes with the egraph optimizations applied. It has been helpful for work on #6260. From discussions in zulip, it seemed more generally desirable.

• I consider some small changes in crates/cranelift/src/compiler.rs to be a bit "hacky", probably due to my inexperience with the borrow checker...
• Maybe there are some CLI error messages you would like introduced (e.g. if the paths for --emit-clif and --emit-opt-clif are the same) — I haven't created any since I'm not even sure about the CLI interface you would prefer.
• The current state does not include support for the wasmtime explorer.

Wasmtime GitHub notifications bot (Aug 20 2024 at 06:46):

dimitris-aspetakis updated PR #9150.

Wasmtime GitHub notifications bot (Aug 20 2024 at 09:45):

github-actions[bot] commented on PR #9150:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Aug 20 2024 at 14:57):

alexcrichton submitted PR review:

Thanks for this! As a possible alternative though, what do you think about not adding a new option but redefining --emit-clif as this option instead? That way optimized clif would be emitted by deafult and non-optimized clif could be emitted with -C opt-level=0

Last updated: Nov 22 2024 at 16:03 UTC