Stream: git-wasmtime

Topic: wasmtime / PR #9146 x64: Fix encoding of adc/sbb with mem...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2024 at 22:14):

alexcrichton requested fitzgen for a review on PR #9146.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2024 at 22:14):

alexcrichton opened PR #9146 from alexcrichton:fix-adc-sbb-encoding to bytecodealliance:main:

This commit is similar to #8976 where it's fixing some typos in the encoding of the adc and sbb instructions used in Cranelift. These appear to have copy/paste typos where the non-register-based opcodes weren't updated from the add and sub opcodes. This problem was exposed from a fuzz test case after #9136 landed. The fuzz test case is minimized and included here as a new runtest and new emit tests are additionally added.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2024 at 22:14):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9146.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2024 at 22:22):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2024 at 22:23):

fitzgen has enabled auto merge for PR #9146.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 19 2024 at 22:42):

fitzgen merged PR #9146.


Last updated: Dec 23 2024 at 13:07 UTC