Wasmtime GitHub notifications bot (Aug 14 2024 at 18:16): Wasmtime GitHub notifications bot (Aug 14 2024 at 18:16):alexcrichton requested elliottt for a review on PR #9131.
Wasmtime GitHub notifications bot (Aug 14 2024 at 18:16):alexcrichton opened PR #9131 from alexcrichton:cmake-newline to bytecodealliance:main:
Looks like CMake before 3.20.0 doesn't generate newlines at all without this configuration option. CMake 3.20.0 and prior, however, generates newlines by default which is why this didn't show up in CI or development.
Closes #9126
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 14 2024 at 18:16):alexcrichton requested wasmtime-core-reviewers for a review on PR #9131.
Wasmtime GitHub notifications bot (Aug 14 2024 at 18:25):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 14 2024 at 18:29):alexcrichton has enabled auto merge for PR #9131.
Wasmtime GitHub notifications bot (Aug 14 2024 at 18:45):alexcrichton merged PR #9131.
Last updated: Oct 23 2024 at 20:03 UTC