Stream: git-wasmtime

Topic: wasmtime / PR #9128 Disable the trace-log feature of rega...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:23):

bjorn3 requested abrown for a review on PR #9128.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:23):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #9128.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:23):

bjorn3 opened PR #9128 from bjorn3:disable_regalloc2_trace_log to bytecodealliance:main:

This makes register allocation a bit faster when these logs are not used.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:27):

cfallin submitted PR review:

It looks like this was (probably accidentally) added as part of #8196 and has been on since March (cc @fitzgen, though I've made the same mistake in PRs before too; this one just slipped through I guess). Thanks for finding it!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:27):

cfallin has enabled auto merge for PR #9128.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:42):

Amanieu commented on PR #9128:

The trace-log feature on cranelift-codegen is also unconditionally enabled.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:43):

Amanieu edited a comment on PR #9128:

The trace-log feature on cranelift-codegen is also unconditionally enabled in the root Cargo.toml for wasmtime-cli.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:46):

cfallin has disabled auto merge for PR #9128.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:46):

bjorn3 requested wasmtime-default-reviewers for a review on PR #9128.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:46):

bjorn3 updated PR #9128.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:47):

bjorn3 commented on PR #9128:

Fixed.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 15:55):

cfallin submitted PR review:

Thanks @Amanieu for catching the top-level change as well!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 16:14):

cfallin merged PR #9128.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 17:27):

fitzgen commented on PR #9128:

Whoops yeah the intention was to enable it by default for clif-util but not for everything all the time!

Last updated: Nov 22 2024 at 16:03 UTC