Stream: git-wasmtime

Topic: wasmtime / PR #9125 Refactor use of `CodeBuilder` on the CLI


view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2024 at 18:49):

alexcrichton opened PR #9125 from alexcrichton:refactor-with-code-builder to bytecodealliance:main:

This commit refactors wasmtime run and wasmtime compile to unconditionally use CodeBuilder internally. This will in theory help out in the future if more debug-related options are added to CodeBuilder for example. This refactoring required some changes to CodeBuilder to be able to support a query about whether the internal bytes were a component or a module. The text format is now converted to binary immediately when supplied rather than during the compilation phase. This in turn required some API changes to make the selection of supporting the text format a compile-time choice of method rather than a runtime value.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2024 at 18:49):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9125.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2024 at 18:49):

alexcrichton requested fitzgen for a review on PR #9125.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2024 at 18:57):

alexcrichton updated PR #9125.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2024 at 19:14):

alexcrichton updated PR #9125.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 17:31):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 17:45):

fitzgen merged PR #9125.


Last updated: Dec 23 2024 at 12:05 UTC