Stream: git-wasmtime

Topic: wasmtime / PR #9113 Clean up dist build configuration

Wasmtime GitHub notifications bot (Aug 12 2024 at 15:47):

alexcrichton opened PR #9113 from alexcrichton:clean-up-build to bytecodealliance:main:

• Move updating $PATH to the main.js script which is the one that mounts /rust/bin so that knowledge isn't spread around.
• Remove some unused env vars in docker containers.
• Forward cargo/rust-specific env vars to the build from outside of containers to the build itself.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 12 2024 at 15:47):

alexcrichton requested abrown for a review on PR #9113.

Wasmtime GitHub notifications bot (Aug 12 2024 at 15:47):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9113.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:14):

alexcrichton updated PR #9113.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:39):

alexcrichton updated PR #9113.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:46):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:50):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:50):

abrown created PR review comment:

Bash inside bash? Not sure I get why it's preferable to do this dance rather than setting things up in the Dockerfile.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:50):

abrown created PR review comment:

  // Forward any rust-looking env vars from the environment into the container

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:56):

alexcrichton updated PR #9113.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:58):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:58):

alexcrichton created PR review comment:

Apparently this particular argument is just informational and used for error messages, so I put "bash" here but any string could work. Otherwise though the main motivation here was to mroe tightly couple the addition of the environment's Rust compiler to the docker image itself. Previously that was spread across this main.js and each Dockerfile, but now it's entirely contained within this main.js alone. In theory that should make the Dockerfile images a bit more freestanding and self-describing.

I realize though in the end this is all intertwined anyway so it probably doesn't help all that much really.

Wasmtime GitHub notifications bot (Aug 12 2024 at 16:58):

alexcrichton has enabled auto merge for PR #9113.

Wasmtime GitHub notifications bot (Aug 12 2024 at 17:28):

alexcrichton merged PR #9113.

Last updated: Dec 23 2024 at 12:05 UTC