Stream: git-wasmtime

Topic: wasmtime / PR #9109 Fix file and line in generated DWARF

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 06:32):

philipc opened PR #9109 from philipc:generated-file to bytecodealliance:main:

We were using a string, but the DWARF standard specifies that: "The value of the DW_AT_decl_file attribute corresponds to a file number from the line number information table...".

Additionally, a typo meant we were overwriting the file attribute with the value that was meant to be used for a DW_AT_decl_line attribute.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 06:32):

philipc requested alexcrichton for a review on PR #9109.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 06:32):

philipc requested wasmtime-core-reviewers for a review on PR #9109.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 06:50):

philipc updated PR #9109.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 14:37):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 14:52):

alexcrichton merged PR #9109.

Last updated: Oct 23 2024 at 20:03 UTC