Stream: git-wasmtime

Topic: wasmtime / PR #9105 Fix more `clippy::doc_lazy_continuati...

Wasmtime GitHub notifications bot (Aug 11 2024 at 14:32):

waywardmonkeys opened PR #9105 from waywardmonkeys:fix-doc-lazy-continuation-lints to bytecodealliance:main:

This fixes all remaining instances of clippy::doc_lazy_continuation except for in some generated code.

Wasmtime GitHub notifications bot (Aug 11 2024 at 14:32):

waywardmonkeys requested cfallin for a review on PR #9105.

Wasmtime GitHub notifications bot (Aug 11 2024 at 14:32):

waywardmonkeys requested wasmtime-compiler-reviewers for a review on PR #9105.

Wasmtime GitHub notifications bot (Aug 11 2024 at 14:32):

waywardmonkeys requested pchickey for a review on PR #9105.

Wasmtime GitHub notifications bot (Aug 11 2024 at 14:32):

waywardmonkeys requested wasmtime-core-reviewers for a review on PR #9105.

Wasmtime GitHub notifications bot (Aug 11 2024 at 15:44):

github-actions[bot] commented on PR #9105:

Subscribe to Label Action

cc @cfallin, @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "isle", "wasi", "wasmtime:api", "winch"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle
• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Aug 12 2024 at 14:50):

alexcrichton submitted PR review:

Thanks!

I'm curious though, how did you see this warning? We should in theory have all lints allowed for clippy by default except a few listed in the top-level Cargo.toml. Do you know how that configuration was ignored?

Orthogonally, if you're up for it, adding this lint to Cargo.toml to have this checked on CI I think would make sense.

Wasmtime GitHub notifications bot (Aug 13 2024 at 07:53):

waywardmonkeys commented on PR #9105:

I found them because I'd added it to the top level Cargo to enable it. :)

I'd wanted to enable it in the commit, but ran into an issue with a couple of remaining ones in generated code and didn't quite have the time at the moment to fix them, but also didn't want merge conflicts on these if I let it all sit until I had the time.

Wasmtime GitHub notifications bot (Aug 13 2024 at 14:04):

alexcrichton commented on PR #9105:

Oops I meant to flag this for merge yesterday. Doing so now.

Also makes sense! And yeah feel free to enable them at the top-level too. It's ok to add #[allow] to generated code as we've done that for ISLE code before (we can perhaps change that to allow(clippy::all) too or something like that)

Wasmtime GitHub notifications bot (Aug 13 2024 at 14:18):

alexcrichton merged PR #9105.

Last updated: Nov 22 2024 at 16:03 UTC