Stream: git-wasmtime

Topic: wasmtime / PR #9100 Remove wasmtime link dep on libm

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2024 at 22:03):

pchickey opened PR #9100 from bytecodealliance:pch/musl_remove_libm_linkage to bytecodealliance:main:

prtest:full

view this post on Zulip Wasmtime GitHub notifications bot (Aug 09 2024 at 22:04):

pchickey updated PR #9100.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2024 at 18:18):

pchickey edited PR #9100:

This was introduced in https://github.com/bytecodealliance/wasmtime/pull/8668 but it doesn't appear to be necessary, and its presence breaks wasmtime-cli builds for x86_64-unknown-linux-musl on linux (tested with AWS2023, a redhat derivative) when using the default linker.

CI overrides the linker with a musl-gcc install. I'm not sure why, and at least in my project, we build without using the musl-gcc linker and everything works perfectly, and adopting that strategy broke something in a way I couldn't debug. So, I'd like it for CI to test the musl build with the default linker as well, to catch issues like this one. The CI matrix / docker configuration is pretty complicated and I was gonna consult with @alexcrichton on the best way to add this check.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2024 at 18:18):

pchickey has marked PR #9100 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2024 at 18:18):

pchickey requested fitzgen for a review on PR #9100.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2024 at 18:18):

pchickey requested wasmtime-core-reviewers for a review on PR #9100.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2024 at 18:18):

pchickey requested alexcrichton for a review on PR #9100.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 14:53):

alexcrichton submitted PR review:

CI overrides the linker with a musl-gcc install. I'm not sure why, ...

This is because our build containers are all Ubuntu so the default linker uses glibc instead of musl. The musl-gcc package is sort of a few wrapper scripts to tell the linker to link musl instead of glibc. In your distro it might be musl-based so this all happens by default perhaps?

In any case looks good to me, now I'm not sure why I needed this but maybe I got something wrong while developing this and accidentally thought it was required.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 15:12):

alexcrichton merged PR #9100.

Last updated: Nov 22 2024 at 17:03 UTC